search

mrDoctorWho / ejabberd_mod_apns

An ejabberd module to send PUSH messages to iOS devices through APNS
MIT License
33 stars 19 forks source link

ejabberd.hrl Does not exist in Ejabberd 18.12 #29

Open BesatZardosht opened 5 years ago

BesatZardosht commented 5 years ago

ejabberd.hrl Does not exist in Ejabberd 18.12. How should this module be compiled

mrDoctorWho commented 5 years ago

Thanks @BesatZardosht, I will look into it.

But why did you update your ejabberd in the first place? You should be aware that community-developed modules aren't being updated on a regular basis.

BesatZardosht commented 5 years ago

Thanks. There was some security changes and some features that was needed in the latest version of Ejabberd. I have modified the module. I will submit a MR soon. :)

mrDoctorWho commented 5 years ago

Hey @BesatZardosht. I don't want to push you.

It's just — if you could find any time to PR your changes that would have been great. Otherwise, I think, I could update the module myself. I just don't wanna do anything that is already done by someone.

BesatZardosht commented 5 years ago

We are working on it. We are adding new features as well like unregistering a token and lots more. Will advise as soon as it's ready. But in the mean while if you want to fix this please do. Thanks

zainspresso commented 3 years ago

@BesatZardosht Did you end up finishing the module?