mrJean1 / PyGeodesy

Pure Python geodesy tools
https://mrjean1.github.io/PyGeodesy/
297 stars 58 forks source link

example ellipsoidalVincenty.py does not work #3

Closed GliderGeek closed 7 years ago

GliderGeek commented 8 years ago

the following example can be found on the top of the file:

Here's an example usage of Vincenty:

      >>> from geodesy.ellipsoidalVincenty import LatLon
      >>> Newport_RI = LatLon(41.49008, -71.312796)
      >>> Cleveland_OH = LatLon(41.499498, -81.695391)
      >>> print(Newport_RI.distance(Cleveland_OH))
      866,457.166175  # meter == 538.3904451566326 miles

LatLon object does not have the distance() function. Probably this should be distanceTo()

mrJean1 commented 8 years ago

The method names in the Python version may be different from the original JS version. If so, the original JS name should also as well.

mrJean1 commented 8 years ago

There are 2 distance methods for ellipsoidal Vincenty LatLon called distanceTo and distanceTo3. But there is no method called distance.

mrJean1 commented 8 years ago

Also, that very same test is included in the tests directory, see module testElipsoidal.py results test 1 under testing geodesy.ellipsoidalVincenty and module tests.py under method testVincenty.

GliderGeek commented 7 years ago

why did you close the issue? the wrong example is still in the file.

mrJean1 commented 7 years ago

My misunderstanding. Module ellipsoidalVincenty has been corrected.

mrJean1 commented 7 years ago

Thank you.