search

mrWh1te / Botmation

A simple TypeScript framework for declaratively composing bots with Puppeteer
https://botmation.dev
MIT License
18 stars 2 forks source link

An in-range update of puppeteer is breaking the build #26

Closed greenkeeper[bot] closed 3 years ago

greenkeeper[bot] commented 4 years ago

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The dependency puppeteer was updated from 3.0.4 to 3.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

puppeteer is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **Travis CI - Branch:** The build **failed**.
Release Notes for v3.1.0

Raw notes

8ba3675 - chore: mark version v3.1.0 (#5883)
a17bd89 - feat: add securityDetails.subjectAlternativeNames() #5628 (#5881)
e823289 - feat(chromium): roll Chromium to r756035 (#5879)
ad3613d - docs(contributing): clarify list of Chromium versions (#5878)
dc26b8d - docs(examples): add cucumber-puppeteer-example for integration testing (#5875)
3e76554 - chore: fix async dialog specs when they fail (#5859)
b2552e4 - chore: restore page.setUserAgent test (#5868)
39f1b13 - chore: extract Request and Response into its own module (#5861)
b510c35 - chore: fetch Firefox from JSON source instead of RegExp (#5864)
69c38fc - chore: extract ConsoleMessage and FileChooser into its own module (#5856)
0aba6df - chore: force Mocha to exit on CI (#5862)
9368edb - chore: upgrade TypeScript to 3.9 (#5860)
5f42547 - chore: extract SecurityDetails into its own module (#5858)
f5d2597 - chore: add running TSC to test README (#5852)
c6d01c9 - chore: extract BrowserRunner into its own module (#5850)
b38bb43 - Warn when given unsupported product name. (#5845)
6099272 - chore: add @types/proxy-from-env (#5831)
5343c7a - chore: private-ise src/Accessibility.ts (#5832)
ce09742 - feat: add more options to check_availability script (#5827)
5103540 - chore: add command to run eslint with --fix flag (#5829)
49ce659 - chore: remove src/TaskQueue (#5826)
4fdb1e3 - chore: add Prettier (#5825)
ae576af - chore: mark v3.0.4-post (#5824)

Commits

The new version differs by 23 commits.

  • 8ba3675 chore: mark version v3.1.0 (#5883)
  • a17bd89 feat: add securityDetails.subjectAlternativeNames() #5628 (#5881)
  • e823289 feat(chromium): roll Chromium to r756035 (#5879)
  • ad3613d docs(contributing): clarify list of Chromium versions (#5878)
  • dc26b8d docs(examples): add cucumber-puppeteer-example for integration testing (#5875)
  • 3e76554 chore: fix async dialog specs when they fail (#5859)
  • b2552e4 chore: restore page.setUserAgent test (#5868)
  • 39f1b13 chore: extract Request and Response into its own module (#5861)
  • b510c35 chore: fetch Firefox from JSON source instead of RegExp (#5864)
  • 69c38fc chore: extract ConsoleMessage and FileChooser into its own module (#5856)
  • 0aba6df chore: force Mocha to exit on CI (#5862)
  • 9368edb chore: upgrade TypeScript to 3.9 (#5860)
  • 5f42547 chore: extract SecurityDetails into its own module (#5858)
  • f5d2597 chore: add running TSC to test README (#5852)
  • c6d01c9 chore: extract BrowserRunner into its own module (#5850)

There are 23 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

github-actions[bot] commented 4 years ago

Thank you for submitting an issue! We greatly appreciate it. We will follow up as soon as we can.

greenkeeper[bot] commented 4 years ago

After pinning to 3.0.4 your tests are passing again. Downgrade this dependency 📌.

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v3.2.0

Highlights

  • We now support emulating vision deficiency types within Puppeteer using page.emulateVisionDeficiency. You can read more about these on the DevTools update blog post.

  • We now use Mitt as the Event Emitter that backs many of Puppeteer's classes rather than the EventEmitter module that ships with Node. This is potentially a breaking change if you rely on some of the less popular EventEmitter methods as Puppeteer's EventEmitter does not support the entire suite of NodeJS EventEmitter functions. We think it's unlikely anyone has relied on these; we were able to swap out the EventEmitter in Puppeteer without any unit tests needing to change.

  • Puppeteer now recognises webviews as regular pages which means you can control them just like you would control a regular page.

Behind the scenes

  • The Request class has been renamed to HTTPRequest to avoid a clash with TypeScript's Request type. We'll be making similar changes to Response and Worker. This is not a breaking change as Puppeteer doesn't directly expose these classes so you shouldn't be referring to them by name in your code.

Raw Notes

1d4d25a - chore: use Mitt as the Event Emitter (#5907)
a2ba6f0 - feat: recognize webviews as regular pages (#5905)
8e8a9df - chore: rename Request class to HTTPRequest (#5934)
9737059 - chore: remove doclint generate_types code (#5932)
7eab7f8 - feat(api): add page.emulateVisionDeficiency(type) (#5901)
24ac11e - chore: fix undefined rm in mocha-utils (#5920)
6cfe142 - chore: don't use expect within Promises (#5466) (#5473)
dfb2e60 - chore: stop Protocol types being globally available (#5899)
d8e0557 - chore: update Travis to run latest macOS and fix HTTPS test (#5903)
9a08d31 - chore: error if coverage couldn't find the given class (#5863)
caaf4d2 - fix: support async functions as an argument for waitForFunction (#5682)
e6c22da - chore: bump version to v3.1.0-post (#5884)

Commits

The new version differs by 13 commits.

  • 88b5265 chore: mark version v3.2.0 (#5937)
  • 1d4d25a Use Mitt as the Event Emitter (#5907)
  • a2ba6f0 feat: recognize webviews as regular pages (#5905)
  • 8e8a9df chore: rename Request class to HTTPRequest (#5934)
  • 9737059 chore: remove doclint generate_types code (#5932)
  • 7eab7f8 feat(api): add page.emulateVisionDeficiency(type) (#5901)
  • 24ac11e chore: fix undefined rm in mocha-utils (#5920)
  • 6cfe142 Don't use expect within Promises (#5466) (#5473)
  • dfb2e60 chore: stop Protocol types being globally available (#5899)
  • d8e0557 chore: update Travis to run latest macOS and fix HTTPS test (#5903)
  • 9a08d31 chore: error if coverage couldn't find the given class (#5863)
  • caaf4d2 fix: support async functions as an argument for waitForFunction (#5682)
  • e6c22da chore: bump version to v3.1.0-post (#5884)

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v3.3.0

Highlights

  • The migration from Node's EventEmitter to the Mitt library has been reverted in this release. We're sorry for causing unexpected issues in the 3.2.0 release. If you were unable to upgrade from 3.1.0 to 3.2.0, you will be able to upgrade straight to 3.3.0 and not have any issues.

Behind the scenes

  • The Puppeteer Response class was renamed HTTPResponse to avoid a clash with the TS Response type. We don't expose this class on the main Puppeteer instance so this shouldn't affect any of your code.
  • Similarly we have renamed Worker to WebWorker to avoid a clash with the TS Worker type.

Raw Notes

34c0f9b - chore: mark version v3.3.0
309d811 - chore: Revert Mitt due to breaking changes (#5952)
81e3248 - chore: Defer Windows FF tests for longer (#5954)
b874cac - chore: rename Worker to WebWorker (#5941)
7862484 - chore: update request and response references in docs (#5942)
232def0 - chore: rename Response to HTTPResponse (#5940)
cfd72ac - chore: bump version to v3.2.0-post (#5938)

Commits

The new version differs by 7 commits.

  • e84e579 chore: mark version v3.3.0 (#5959)
  • 309d811 chore: Revert Mitt due to breaking changes (#5952)
  • 81e3248 chore: Defer Windows FF tests for longer (#5954)
  • b874cac chore: rename Worker to WebWorker (#5941)
  • 7862484 chore: update request and response references in docs (#5942)
  • 232def0 chore: rename Response to HTTPResponse (#5940)
  • cfd72ac chore: bump version to v3.2.0-post (#5938)

See the full diff

mrWh1te commented 4 years ago

Maybe try out the PR at jest-puppeteer for keeping the page/tab open via config, fork it, then understand it/clean it up/tie up loose ends, then try it out as a means to stabilize e2e testing with later Puppeteer versions

Much tbd

edit: maybe try out puppeteer-cluster as it has an approach towards parallelizing puppeteer tests 🎯

edit2: probably majority of tests don't actually use a puppeteer page but a mock object so could potentially replace jest-puppeteer for something that mixes puppeteer-cluster for tests that do use an actual page... could require a large code refactor, but could organize tests that use a page into test-suites with hooks that setup the page for the tests, perhaps clustering them

mrWh1te commented 4 years ago

I've tested Botmation with newer Puppeteer versions with no problems, but the e2e tests seem to grow more unstable as more are added and the errors are all very similar, race conditions for things in the page when the page no longer exists? Strange