Fix yappFromInside vertical positioning for cutouts on lid

mrWheel / YAPP_Box

Yet Another Parametric Projectbox Box

https://willem.aandewiel.nl/index.php/2022/01/02/yet-another-parametric-projectbox-generator/

MIT License

267 stars 46 forks source link

Fix yappFromInside vertical positioning for cutouts on lid #105

Closed sakana280 closed 1 month ago

sakana280 commented 1 month ago

Hi @mrWheel, these changes I think will fix the vertical positioning of lid cutouts using the yappFromInside option. I've tested this for cutouts on lid, base, and sides, with and without yappFromInside, and with and without masks. I'm not sure if this PR properly accounts for the direction of the +/-0.02 z-enlargements and offsets, but they are small enough offsets I haven't observed any issue when testing.

mrWheel commented 1 month ago

@rosenhauer

can you review and merge this pull request?

sakana280 commented 1 month ago

Thank you!