mrWheel / YAPP_Box

Yet Another Parametric Projectbox Box
https://willem.aandewiel.nl/index.php/2022/01/02/yet-another-parametric-projectbox-generator/
MIT License
276 stars 46 forks source link

Add additional text options and pcbStand pin options #62

Closed rosenhauer closed 10 months ago

rosenhauer commented 10 months ago

Add four additional text options (to match what's available in OpenSCAD.

//   p(9) = Direction : { <yappTextLeftToRight>, yappTextRightToLeft, yappTextTopToBottom, yappTextBottomToTop }
//   p(10) = Horizontal alignment : { <yappTextHAlignLeft>, yappTextHAlignCenter, yappTextHAlignRight }
//   p(11) = Vertical alignment : {  yappTextVAlignTop, yappTextVAlignCenter, yappTextVAlignBaseLine, <yappTextVAlignBottom> }
//   p(12) = Character Spacing : Default = 1

With examples in WaterHeaterMonitor_v3.scad. image

rosenhauer commented 10 months ago
  1. Add Custom pin length option to pcbStand
  2. Add yappTopPin option (in addition to , yappHole)
  3. Removed the forced color on the Hooks image
mrWheel commented 9 months ago

Dear @rosenhauer, Given the amount of new functionality and options I’m loosing track of the possibilities (also due to limited time on my side). Would you mind editing / appending the “Official Documentation” in gitbook?

If so I think you have to create an account on gitbook and give me your account name (I think) so I can add you as a collaborator.

GitBook add Collaborators

I’m not sure collaborating with Personal accounts is possible. Sended a question to the GitBook team.

rosenhauer commented 9 months ago

I signed up for a Personal account. Same username as GitHub.

mrWheel commented 9 months ago

Ok, if I understand it right you can follow this link

rosenhauer commented 9 months ago

I made a few changes and sent them for your review, Just to check out the process.

I can work my way through the entire document making sure that all of the changes/additions are documented.

Do you like the idea of adding subpages for the optional parameters to keep the main pages cleaner?

On Tue, Jan 30, 2024 at 12:04 PM mrWheel @.***> wrote:

Ok, if I understand it right you can follow this link https://app.gitbook.com/invite/-M0s3OOkvpRGMMljA00t/-M0s3PkDnxkFYcwjURMJ

— Reply to this email directly, view it on GitHub https://github.com/mrWheel/YAPP_Box/pull/62#issuecomment-1917605839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBTUKHMRXZZ6TFWJAB25S3YREY2DAVCNFSM6AAAAABCK724DGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGYYDKOBTHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Dave

mrWheel commented 9 months ago

I will look at the changes you made.

Subpages for optional parameters is a great idea.

If you get to it, for parameters with a default value: please show them as first parameter in the list:

parm = {<rectangle> | circle | something_else }

Where rectangle is the default value

mrWheel commented 9 months ago

@rosenhauer,

Well , I see you did some additions to the documentation.

But every time I now open gitbook in [edit] mode I see different things (?). An error that syncing did not go well. Also a lot of changes I made months ago that have to be merged .. but then I get conflicts so I archived those changes.

I will, for the time being not enter gitbook in [edit] mode, just to make sure I won’t destroy your work!

So, please merge your changes yourself. I have confidence your English is far better than mine!