search

mraaroncruz / guard-uglify

A guard library for uglifyjs javascript file compression (through the uglifier gem)
10 stars 17 forks source link

Update to follow Guard 2.0 changes #5

Closed ezekg closed 9 years ago

ezekg commented 9 years ago

Getting deprecation warnings. More info is here.

09:37:50 - WARN - Starting with Guard 2.0, Guard::Uglify should inherit from Guard::Plugin
> [#] instead of Guard::Guard.
> [#] Please note that the constructor signature has changed from
> [#] Guard::Guard#initialize(watchers = [], options = {}) to
> [#] Guard::Plugin#initialize(options = {}).
> [#] For more information on how to upgrade for Guard 2.0, please head over
> [#] to: https://github.com/guard/guard/wiki/Upgrading-to-Guard-2.0#changes-in-guardguard
> [#]
> [#] Deprecation backtrace: /Library/Ruby/Gems/2.0.0/gems/guard-2.8.2/lib/guard/ui.rb:107:in `deprecation'
> [#]    >/Library/Ruby/Gems/2.0.0/gems/guard-2.8.2/lib/guard/guard.rb:94:in `initialize'
> [#]    >/Library/Ruby/Gems/2.0.0/gems/guard-uglify-0.2.0/lib/guard/uglify.rb:9:in `initialize'
mraaroncruz commented 9 years ago

If you want to make a pull request that would be great. I don't use this project and it will probably be awhile until i fix anything. sorry, aaron

ezekg commented 9 years ago

For sure. If I create a pull request, will you update the gem?

mraaroncruz commented 9 years ago

Yessiree!

ezekg commented 9 years ago

Done. :+1:

ezekg commented 9 years ago

Thank ya sir.

mraaroncruz commented 9 years ago

I pushed to rubygems too and gave you gem push access