mracko / MSFS-Mobile-Companion-App

Mobile Companion App for MSFS 2020
GNU Affero General Public License v3.0
355 stars 42 forks source link

Integration with Find My Plane #24

Open hankhank10 opened 3 years ago

hankhank10 commented 3 years ago

Good morning.

By way of introduction I am one of the contributors to the Python-SimConnect library and originally built the flask/web/http integration on which your repo is based.

I'm really impressed with what you have done here - it is very comprehensive, much more so than my initial attempt at this.

My latest project is called Find My Plane (https://findmyplane.live) which is a simple flight tracker which allows users to track their flights - and those of others - through a web interface running remotely. It is free and open source.

At present this shows traffic from users using either my own client (based on Python-SimConnect) and the Fly By Wire A320neo which has an API which I pull in data from. It should make multiplayer meet ups much easier and is a very simple way for non technical users to get their flight location on another device without worrying about eg IP addresses, ports, etc.

The server supports input through a simple REST api so is client agnostic and I am keen to make this as open to as many other clients as possible to stop people having to download and run multiple different clients.

Would you consider adding an option to your application to allow your users to send their plane location data to this API? I would be happy to prepare a pull request which would demonstrate how this would work, but wanted to check whether you would be open to it before I did.

Thanks Mark

mracko commented 3 years ago

Hi Mark!

Thank you for your message. It's great to meet one of the devs of the original MSFS 2020 Cockpit Companion App. I was very impressed when I first saw it and knew right away that it'll be my starting point for a "mobile" companion app which I was missing for MSFS.

I had a quick look at your new app and I like the idea a lot. IP address/port conflict is the number 1 issue users have with the current local webserver solution. I'm always open to expanding the functionality of the Mobile Companion App so I'd be very happy to look at your pull request.

I was very busy the last couple of weeks so I didn't really have time to move the development of this app forward. Nevertheless, I want to update the UI today or tomorrow with an optional map/controls split-screen mode for tablets in landscape mode. I know, I'm going full circle on your original concept. :)

Looking forward to your pull request!

Martin

PS: Which map provider are you using? It looks like Stadia (probably even vector-based), but I may be mistaken.

hankhank10 commented 3 years ago

Great. I will get going on the pull request.

hankhank10 commented 3 years ago

I have raised an initial pull request for this integration.

It probably makes sense to merge this into a dev branch rather than main once you have given it an initial review.

Thanks

hankhank10 commented 3 years ago

I have raised a fresh pull request for this here: https://github.com/mracko/MSFS-Mobile-Companion-App/pull/38