search

mracko / MSFS-Mobile-Companion-App

Mobile Companion App for MSFS 2020
GNU Affero General Public License v3.0
362 stars 39 forks source link

Weather Addon #28

Open Pontiac51 opened 3 years ago

Pontiac51 commented 3 years ago

Hi,

as discussed I have added weather information as this is usually not available in MSFS unless you have ATIS or a glass cockpit with that information.

I have included the following parameters on the "Other" page:

Sea level pressure in inHg and mbar Ambient pressure in inHg and mbar Ambient temperature in °C and °F Ambient visibility in meters (according to WMO standard) and miles

2 compass roses indicate wind direction and velocity in kts First compass rose is north orientated Second compass is heading orientated

Wind components (aircraft lateral and longitudinal aka crosswind, head- and tailwind) in kts

I hope you find this useful!

mracko commented 3 years ago

Thanks for the pull request. I'll have a look at it over the next couple of days. Just so that you know - I'll be updating the app with a new map/controls split-screen mode for tablets in landscape mode. From what I've seen, this shouldn't have compatibility issues with your pull request. Maybe the menu_other.html will require manual fixing, but nothing complicated.

One important question: I've noticed that you've added 5 new vars for SimConnect to pull. I've been very cautious with adding new vars because with each addition the response time for data going from the sim to the app gets worse. I'm planning on adding other essential controls like flaps, gear, spoilers, trim wheel etc so I'm worried about having too many variables that would make the app painfully slow. Did you compare the response times of your version with the original?

Thanks!

Pontiac51 commented 3 years ago

I did not specifically test this, but I was quite happy with the performance. We could leave one or two variables out if it is a concern. The ambient pressure and the sea level pressure (pressing B does do the same) are not really required, it is just a bonus.

Can’t wait to see the new version.

Cheers!

Pontiac51 commented 3 years ago

Would it be possible to pull only the variables the page has to display? That should help. A friend of mine suggested to use Websockets, but that would be a bigger overhaul.

mracko commented 3 years ago

As far as I have seen, the performance/latency problem is due to Python SimConnect. Switching to native C++ SimConnect would solve the issue, but I have no C++ experience.

I have updated the master to v1.5 which add the landscape mode. You can switch to the landscape mode in the Others tab. I'll look at your code some time next week and give you feedback.

mracko commented 3 years ago

I've been busy finishing v1.5 this week but I'll have a look at your weather additions in the next couple of days.

mracko commented 3 years ago

Hi @Pontiac51 ! Just want to let you know that I haven't forgotten about the weather info. I've made a new Data tab where this info would make perfect sense. I haven't implemented it yet because I don't want to include too many variables unnecessarily. I'm thinking of adding a third thread for additional SimConnect vars to keep the latency under control.