mracko / MSFS-Mobile-Companion-App

Mobile Companion App for MSFS 2020
GNU Affero General Public License v3.0
362 stars 39 forks source link

Updated menu_nav & menu_com to show decimal point on iOS #37

Closed fitzroymckay closed 3 years ago

fitzroymckay commented 3 years ago

I updated menu_nav and menu_com to show decimal point on iPhone when in direct input mode

The input mode just needed to be switched from numeric to decimal. I suppose it will work on Android too, but I cannot test.

mracko commented 3 years ago

Thanks for finding this bug. I don't have an iOS device so I haven't noticed it myself. I'll test this on my Android devices and will let you if everything is OK.

mracko commented 3 years ago

I've finally managed to have a look at it and you're right - the keyboard on the iOS didn't show the decimal button. I've missed it because it was never an issue on my Android tablet.

However, your fix doesn't fully solve the issue. When you have a "European" iOS, the keyboard will show a comma instead of a dot. Unfortunately, the app doesn't recognize a comma as a decimal separator so you still can't type in a decimal frequency. A simple solution would be to add a JavaScript function that replaces commas with dots. Do you think you could do it? Otherwise I'll have a look at it, hopefully, next week.

Thanks a lot!

fitzroymckay commented 3 years ago

I have added a lang="en-US" field in the frequency input box, I believe that should fix it. It shows a dot on my iOS even though I have switched to a french keyboard only.

I have also corrected inputmode to decimal for ADF, I had forgotten it last time

mracko commented 3 years ago

I've merged your commit into the master branch. Thanks a lot for your fix! I've made two additions/changes to the code:

fitzroymckay commented 3 years ago

Thank you!