search

mracko / MSFS-Mobile-Companion-App

Mobile Companion App for MSFS 2020
GNU Affero General Public License v3.0
355 stars 42 forks source link

Find My Plane integration - revised #38

Open hankhank10 opened 3 years ago

hankhank10 commented 3 years ago

Thank you for your comments on the previous pull request.

Given there was a new master version I thought it easier to refork and do a fresh pull request, which this is. I will close the previous one and link here.

With respect to your previous comments:

Needs to be updated to v1.5.1 (this is an obvious one)

Done. This is now based on the latest version and all changes are against that.

I was having issues when the MCA was open in multiple browsers. It seems that multiple clients are causing issues.

I haven't actually been able to replicate this but I suspect that it is due to too many requests being sent when multiple clients are open. I have implemented a throttling mechanism which means that an update is sent no more than once a second (and in practice less than this) which should fix the issue.

Opening the FMP link didn't always work at first. Sometimes I had to refresh the page. This could be related to 2.

I think the link actually did work but didn't refresh the button in a timely way to make clear that it had worked. I have fixed this by forcing a status refresh on the button as soon as the request is completed which is a much better UX experience.

I've set up a Home Screen button on Android to access the MCA so it runs in full screen. If you click the FMP link, then it opens in the same window. It would be great to force it to open in a regular browser to make it multi-task capable. This is also the case on iOS.

This was actually quite hard to fix as it is difficult to get links called by javascript to force a new browser window. I have fixed this by changing it to an link which then calls an endpoint in flask to do the redirect. It now works as expected, although I haven't actually been able to roadtest in Android.

I'd change the default value state to disconnected. I don't want to force users to share their position by default.

Done.

I'd position the tab behind "Other".

Done.

How about renaming the tab button to "FMP online" or "FMP" - just to keep it short.

I've shortened to "Find online" (normal) and "Find" (landscape). I didn't like FMP as I don't think it will be clear to users what that actually is.

The width of the tab button needs fixing. See below:

Done

I would be grateful for your test, review and comments.

Thanks

mracko commented 3 years ago

Thanks for the great work! I'll try to test it next week so I can give you feedback. Unfortunately, I've been really busy the last couple of week so I didn't have much time for this app. Just so that you know, I'm planning on releasing a hotfix for the NAV/COM decimal and negative VS values on iOS this week.

hankhank10 commented 3 years ago

Just checking in on this as to whether you have had a chance to review?

hankhank10 commented 1 year ago

@mracko Are you open to reconsidering this pull request to integrate Find My Plane? If so I will revise the code and open another pull request but don't want to if you're not open to it / this project is abandoned

Thanks