search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

CustomMode view frame issue #103

Open songjisj opened 8 years ago

songjisj commented 8 years ago

Now MRProgress forces the provided custom view to be a square if using CustomMode, related code in manualLayoutSubviews in MRProgressOverlayView:

modeViewFrame = CGRectMake(modePadding, y, innerViewWidth, innerViewWidth);

Could you use the height which the custom view provides? Suggested change like:

modeViewFrame = CGRectMake(modePadding, y, innerViewWidth, self.modeView.frame.size.height);

Thank you.

mrackwitz commented 8 years ago

You're right. Using the provided height would make much more sense here. Are you eager to put together a PR for that? That would be welcome.