Handles circular progress overlay views with empty text strings correctly (they weren’t centered properly earlier)

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress

MIT License

2.55k stars 306 forks source link

Handles circular progress overlay views with empty text strings correctly (they weren’t centered properly earlier) #11

Closed pxlshpr closed 10 years ago

pxlshpr commented 10 years ago

There's still a little issue with creating a circular progress overlay (with no text), and then later trying to update it with some text—because the frame of the progress overlay is now too small to accommodate that text.

Not sure what the best course of action would be for this case?

mrackwitz commented 10 years ago

I won't merge 4267fec. I would recommend using UIApperance-API instead of another factory method with more parameter. I have merged c927653, but had to fix layout for small indicator modes without text. Thank you anyway!