Adds completion blocks to dismiss methods

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress

MIT License

2.55k stars 306 forks source link

Adds completion blocks to dismiss methods #19

Closed torben closed 10 years ago

torben commented 10 years ago

Hi @mrackwitz,

I've just added completion callbacks for the dismiss methods. I want to make sure, that the animation has ended, when I call my action. Let me know what you thinking.

Greets Torben ;)

mrackwitz commented 10 years ago

Hi @torben, great work! But I would rather keep the existing dismiss methods for convenience instead of deprecate them, since you won't need the completion block in all situations, e.g. if you dismiss the view without animations. Maybe we should publish the existing private method hide:completion:, too.

torben commented 10 years ago

:+1:

mrackwitz commented 10 years ago

:shipit: