search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

Stop button animation broken #34

Closed coneybeare closed 10 years ago

coneybeare commented 10 years ago

On an MRCircularProgressView with mayStop enabled, tapping the square does not animate it's size as it is supposed to. This works in the activity indicator view, but not the circular progress view. It is reproducible on master in the example project.

Furthermore, I think that your contract ration (set at 1/3 of the size) should be configurable. If you are going to show activity on a tap, it shouldn't be hidden by the fingertip. If you allowed us to set this to something larger than the original size, then it would be noticeable.

Another option would be to shrink the size of the entire progress view instead of just the stop button.

The stop button is also a bit too small when the progress indicator is used at a 48x48 size. I have solved this locally by adding a gesture recognizer to the entire progress view that calls the stop method, but perhaps you could have a configuration option to do the same internally.

Sorry for overloading this single bug report with feature requests but they are all relevant to the stop button.

mrackwitz commented 10 years ago

Hi @coneybeare, thank you for the very descriptive report. I would prefer to split this to multiple issues. Do you want to open new two issues for the feature requests?

This would be helpful.

mrackwitz commented 10 years ago

On an MRCircularProgressView with mayStop enabled, tapping the square does not animate it's size as it is supposed to. This works in the activity indicator view, but not the circular progress view. It is reproducible on master in the example project.

This is a bug. I will try to look into that soon.