search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

Too small hit area for stop button in small progress indicators #38

Closed mrackwitz closed 9 years ago

mrackwitz commented 10 years ago

As originally described in #34 by @coneybeare:

The stop button is also a bit too small when the progress indicator is used at a 48x48 size. I have solved this locally by adding a gesture recognizer to the entire progress view that calls the stop method, but perhaps you could have a configuration option to do the same internally.

mrackwitz commented 10 years ago

This is an issue. I already thought about that, when changing the implementation, because it affected the way how the touch area is recognized. I think a gesture recognizer is the most appropriate solution for that, at the moment. How else you would handle the difference between a 200x200 and a 48x48 size? We could ensure that the touch area is at least the min touch region size by Apple HIG 44x44 in the center of the component, but this could also cause surprises.