mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

Features: iOS8 UIVisualEffectView Support #51

Closed mrackwitz closed 9 years ago

mrackwitz commented 9 years ago

Uses UIVisualEffectView in combination with UIBlurEffect for the blur in MRProgressOverlayView.

marcelofabri commented 9 years ago

GM is out now :+1:

mrackwitz commented 9 years ago

Thanks for the reminder. :+1:

But there is an issue with UIVisualEffectView only on iPhone 6 and iPhone 6P if a mask is applied, which causes that transformations are applied, which do not only affect offscreen rendering, but also the current screen's contents. This causes again trouble with flickering. :unamused: The mask needs to be applied because UIVisualEffectView's layer doesn't support cornerRadius.

marcelofabri commented 9 years ago

Have you tried adding UIVisualEffectView to an UIView and setting the cornerRadius on it (instead of using a mask)?

mrackwitz commented 9 years ago

@marcelofabri: Yes, I tried it now again on GM, but this still don't work. Perhaps this is related to something deep in the rendering chain and have to do with the downsampling used on iPhone 6+.

mrackwitz commented 9 years ago

Update: Rebased. I've finally setup a sample project and filed a rdar://18466755 for the flicker issue.

mrackwitz commented 9 years ago

Update: The flickering is specific for using the "classic" resolution on iPhone 6. So this is now ready for merge and release, as there is an issue with "classic" resolution with the old method, too.