search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

Support stricter compiler checks #53

Closed dschneller closed 9 years ago

dschneller commented 9 years ago

In our project we have "-Werror" active and quite a few more compile time checks turned on. This pull request offers trivial changes that make make MRProgress classes compile in stricter environments. Where sensible I changed the code slightly, in other places I added pragmas to suppress individual warnings because it seemed acceptable in these cases or it is code taken from another party (e. g. Apple).

mrackwitz commented 9 years ago

Thank you for your pull-request. Can you perhaps list the other compiler flags, you have active or directly configure the static library project, so that it will output at least warnings for that, too? So we could ensure that those won't fail for future changes.

dschneller commented 9 years ago

This is what we are using in our project.

WARNING_CFLAGS = -Weverything -Wno-objc-missing-property-synthesis -Wno-covered-switch-default -Wno-direct-ivar-access -Wno-gnu-statement-expression -Wno-float-equal -Wno-assign-enum -Wno-format-nonliteral -Wno-undef -Wno-documentation -Wno-unused-macros

mrackwitz commented 9 years ago

You don't need to create a separate PR. I picked up a new branch on base of this PR and fixed some other issues after merging back the current changes from master. Furthermore I could find a small bug through the stricter warnings. But thanks for the answer and reporting anyways. :+1:

dschneller commented 9 years ago

Yes. I changed the comment in the meantime anyway, because I was too lazy to go back and create another branch. So the PR just has the changed settings added to it now.

On 08 Aug 2014, at 13:08, Marius Rackwitz notifications@github.com wrote:

You don't need to create a separate PR. I picked up a new branch on base of this PR and fixed some other issues after merging back the current changes from master. Furthermore I could find a small bug through the stricter warnings. But thanks for the answer and reporting anyways.

— Reply to this email directly or view it on GitHub.