search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

fix orientation bug on iPad iOS 8 #67

Closed ulechka closed 9 years ago

ulechka commented 9 years ago

I worked on https://github.com/mrackwitz/MRProgress/issues/65

ssoper commented 9 years ago

+1

mrackwitz commented 9 years ago

Thanks! But this is only applicable for iOS 8+ so far. I'd like to warrant iOS 7 backwards-compatibility. Could you revert those changes, and ensure the code is only executed if the OS version is greater or equal 8? Furthermore on iOS 8 the blurred background will be wrong rotated, caused by the rotation, which is applied here. So this need to be OS version specific like all the deleted lines, too.

Btw. why did you based your work on fix/42_ipad_orientation_flicker? This branch is stale since longer and not updated. Does this still solve any current issues for you?

romanr commented 9 years ago

Instead of removing the code simply add if around those blocks:

if (![[[UIDevice currentDevice] systemVersion] compare:@"8.0" options:NSNumericSearch] != NSOrderedAscending) {
///
}