search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 306 forks source link

0.8.0-alpha1 crashes app #72

Closed jeffreyjackson closed 9 years ago

jeffreyjackson commented 9 years ago

I'll post the debugger information later today.

mrackwitz commented 9 years ago

Thanks for your feedback on this prelease. There are definitively several issues with this version. It is not recommended for production usage.

mrackwitz commented 9 years ago

@jeffreyjackson: Do you had time to gather the crash logs?

jeffreyjackson commented 9 years ago

Sorry, I'll be back on my computer shortly and will pass them along.

jeffreyjackson commented 9 years ago

Well I'm not able to get any debugger info for whatever reason. All I am doing is:

[MRProgressOverlayView showOverlayAddedTo:self.view.superview title:@"" mode:MRProgressOverlayViewModeIndeterminate animated:YES stopBlock:nil];

This is being called from a method whose origin is in - (void)viewWillAppear:(BOOL)animated

mrackwitz commented 9 years ago

Do you surely know that self.view.superview is non-nil? It could be perhaps a memory management issue. It would be helpful if you can provide further information how to reproduce this crash, then I will try to take a look into this soon.

jeffreyjackson commented 9 years ago

Good catch. I am making the check now to ensure superview is not nil before I add the overlay. Now it works without crashing the app. FWIW, 0.7.0 worked fine without checking superview for nil.