search

mrackwitz / MRProgress

Collection of iOS drop-in components to visualize progress
MIT License
2.55k stars 305 forks source link

When using Xcode 6.3 MRNavigationBarProgressView.h, MRCircularProgressVi... #95

Closed RyoAbe closed 9 years ago

RyoAbe commented 9 years ago

When using Xcode 6.3 MRNavigationBarProgressView.h, MRCircularProgressView.h generates a compiler warning as follows:

Auto property synthesis will not synthesize property 'progress'; it will be implemented by its superclass, use @dynamic to acknowledge intention 20d34cf

I've made a pull request #95 20d34cf that seems to take care of the issue by adding the specified @dynamic call in the @implementation, but someone should probably check to make sure that's the correct approach.

But why do you redeclare property on subclass?

mrackwitz commented 9 years ago

I think, I kept the redeclaration of the property to make it more obvious from viewing just the plain headers, how to change the displayed progress value of the views. The animated setter is also redeclared, but it's documentation explains further details about the animation behavior. Thanks for your PR! :+1: