Fix Dart Editor static analysis problems

mraleph / irhydra

Tool for displaying IR used by V8 and Dart VM optimizing compilers

Apache License 2.0

433 stars 32 forks source link

Closed paulfryzel closed 10 years ago

paulfryzel commented 10 years ago

This change fixes all of the current Dart Editor static analysis problems such as type ambiguities, deprecated interfaces, and dead code.

Checked with: Dart Editor version 1.2.0.dev_04_00 (DEV) / Dart SDK version 1.2.0-dev.4.0

mraleph commented 10 years ago

Nice. Thanks a lot for this Paul!

Two small things:

I left a couple of review comments here and there. Could you address them?
I have to follow Google's processes when accepting patches which means you need to sign Individual CLA: https://developers.google.com/open-source/cla/individual (there is a click through form at the end of the page).

I will pull it in after that.

Thanks!

paulfryzel commented 10 years ago

Thanks for reviewing @mraleph! I've made the changes you suggested and signed the CLA.