Splice source into IR (eye icon) no longer works

mraleph / irhydra

Tool for displaying IR used by V8 and Dart VM optimizing compilers

Apache License 2.0

433 stars 32 forks source link

Splice source into IR (eye icon) no longer works #55

Closed krisselden closed 7 years ago

krisselden commented 7 years ago

You can reproduce this with the hydrogen.cfg and code.asm files in /irhydra/web/demos/v8

krisselden commented 7 years ago

Just confirmed that this is working on https://github.com/mraleph/irhydra/commit/dd523dcded37a61415d9707430b68fda741a5361

krisselden commented 7 years ago

This feature though didn't require disassembly before, it worked with Chrome release, but if you default that only if there is disassembly it requires a custom build. Do you mind reopening?

mraleph commented 7 years ago

@krisselden I reworked the fix. Now it should work even if there is no disassembly.

(Unfortunately TurboFan deoptimization mapping does require disassembly).