mraleph / irhydra

Tool for displaying IR used by V8 and Dart VM optimizing compilers
Apache License 2.0
433 stars 32 forks source link

set default to crankshaft after parsing. #56

Closed krisselden closed 7 years ago

krisselden commented 7 years ago

The splice code in IR (eye icon) button used to work with traces from the release Chrome (which does not support disassembly). The current fix for this issue requires code have disassembly.

This change moves setting the default until after parse.

krisselden commented 7 years ago

I see you did a better fix than this

mraleph commented 7 years ago

Sorry, I just went and fixed it right away! :) But don't let this discourage you from sending more PRs :)