search

mransan / ocaml-protoc

A Protobuf Compiler for OCaml
https://mransan.github.io/ocaml-protoc/
MIT License
179 stars 33 forks source link

Js_boolean can't be found. #138

Closed swuecho closed 5 years ago

swuecho commented 5 years ago

742 │ Js_dict.set json "value" (Js_json.boolean (Js_boolean.to_js_boolean v.Admin_types.value)); 743 │ json

The module or file Js_boolean can't be found.

bobzhang commented 5 years ago

We made some improvement so that js Boolean is the same as ocaml boolean

发自我的iPhone

------------------ Original ------------------ From: Hao Wu <notifications@github.com> Date: Sat,Oct 26,2019 4:29 PM To: mransan/ocaml-protoc <ocaml-protoc@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [mransan/ocaml-protoc] Js_boolean can't be found. (#138)

742 │ Js_dict.set json "value" (Js_json.boolean (Js_boolean.to_js_boolean v.Admin_types.value)); 743 │ json

The module or file Js_boolean can't be found.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

swuecho commented 5 years ago

@bobzhang Indeed. Works fine after remove the translation . Thanks.

mransan commented 5 years ago

I'll start working on this project again shortly. Getting back into bucklescript for a small project :)

swuecho commented 5 years ago

@mransan Welcome back. Waiting for anthor release.

mransan commented 5 years ago

So I tried updating to opam 2.x.x but running into some issue with the simple build system that is currently used in ocaml-protoc

https://github.com/ocaml/opam-repository/pull/15156/

I'll start looking at Dune since it seems to be the most common build system.

mransan commented 5 years ago

@swuecho new compiler is published: https://github.com/ocaml/opam-repository/pull/15160

swuecho commented 5 years ago

upgraded and works great! thanks!