mransan / ocaml-protoc

A Protobuf Compiler for OCaml
https://mransan.github.io/ocaml-protoc/
MIT License
179 stars 33 forks source link

Update docs/tests to reflect that sfixed is supported #166

Closed vphantom closed 2 years ago

vphantom commented 2 years ago

Hi! First almost-useful pull request, just some house cleaning. After deeper investigation I discovered that sfixed32 and sfixed64 seem to be supported just fine.

I ran make ; make tests and while a few near the end were strangely verbose (printing out records) they were all displayed in green. Assuming this means a successful run (I honestly have no idea), then this PR makes sense.

If I didn't run the tests properly or in full, please let me know.

mransan commented 2 years ago

I don't think the google unittest is working or enabled. However there is already an integration test which does it.

The best way for you to get familiar with testing would be to be able to run the integration like make test02. Those integration test serialize/deserialize data between the ocaml-protoc and the google protobuf compiler for C++.