search

mransan / ocaml-protoc

A Protobuf Compiler for OCaml
https://mransan.github.io/ocaml-protoc/
MIT License
179 stars 33 forks source link

-unsigned arg: tags uint32/64 with `unsigned #186

Closed mbacarella closed 1 year ago

mbacarella commented 1 year ago

Closes https://github.com/mransan/ocaml-protoc/issues/185

Still very much working on this. The generation works but haven't instrumented my project to actually run it yet.

It's ready to review now.

mbacarella commented 1 year ago

Alright, reworked our project to actually use this. Works! (and found some eyebrow raising unsigned -> signed coercion issues!)

Anyway, ready for your consideration.

mbacarella commented 1 year ago

Thank you @c-cube!

mbacarella commented 1 year ago

I'm noticing the failing CI tests. I'm confused, I run dune build @install locally and don't get those erorrs.

mbacarella commented 1 year ago

Oh, I see, the CI is doing a merge master first.

c-cube commented 1 year ago

Thank you!