search

mransan / ocaml-protoc

A Protobuf Compiler for OCaml
https://mransan.github.io/ocaml-protoc/
MIT License
179 stars 33 forks source link

Use latest Yojson #189

Closed Lupus closed 1 year ago

Lupus commented 1 year ago

Latest Yojson library (version 2 and higher) has dropped legacy json type, would be nice to bump the version of required yojson library along with the corresponding change in code generator. It's very cosmetic change, no other APIs are affected and everything works just fine. See corresponding PR to ocaml-protoc-yojson: https://github.com/mransan/ocaml-protoc-yojson/pull/2

c-cube commented 1 year ago

Should we also move to Yojson.Safe.t? Seems like most projects use this variant…

Lupus commented 1 year ago

Probably this change also makes sense. ppx_yojson_conv is producing Yojson.Safe in generated code as well.