renames isInf/setInf to isNeutral/setNeutral which external libraries might rely on. The transition is just a find/replace.
Rationale
isInf/setInf are for points at infinity which are technically not on the elliptic curve. But in Constantine it is also conflated with the identity/neutral element.
This is true for short Weierstrass curves but not true for Twisted Edwards curves as the neutral elements ARE on the curve.
To allow generic algorithm like scalar multiplication and multi-scalar-mul, we rename everything to isNeutral/setNeutral
This PR is breaking internal API and curves_primitives API.
It:
generator
tosetGenerator
, this has been introduced yesterday in https://github.com/mratsim/constantine/pull/397/commits/8ac73c715240bcdf05d46f80eec15ba339f63848 so unlikely to cause external breakage.isInf
/setInf
toisNeutral
/setNeutral
which external libraries might rely on. The transition is just a find/replace.Rationale
isInf
/setInf
are for points at infinity which are technically not on the elliptic curve. But in Constantine it is also conflated with the identity/neutral element. This is true for short Weierstrass curves but not true for Twisted Edwards curves as the neutral elements ARE on the curve.To allow generic algorithm like scalar multiplication and multi-scalar-mul, we rename everything to
isNeutral
/setNeutral