search

mratsim / constantine

Constantine: modular, high-performance, zero-dependency cryptography stack for verifiable computation, proof systems and blockchain protocols.
Other
413 stars 44 forks source link

Windows: Secp256k1 tests assembly test frozen #448

Open mratsim opened 4 months ago

mratsim commented 4 months ago

Since #444 the tests on Windows are frozen with Secp256k1 assembly:

image

This is blocking #445 as it changes the assembly.

The big difference for secp256k1 is that due to using the full 256-bit the final substraction needs to handle an extra underflow condition here:

https://github.com/mratsim/constantine/blob/fef6fdcdc3f256fb71a3ee2e28bff80000bbb33d/constantine/math/arithmetic/assembly/limbs_asm_modular_x86.nim#L55-L91