mratsim / constantine

Constantine: modular, high-performance, zero-dependency cryptography stack for verifiable computation, proof systems and blockchain protocols.
Other
413 stars 44 forks source link

fix MSM bench using 64-bit scalars after #444 [skip ci] #460

Closed mratsim closed 3 months ago

mratsim commented 3 months ago

While implementing #444, I changed the MSM benchmarks to use 64 bits scalars (and 128 and 192 ...) to evaluate the endomorphism bit-threshold https://github.com/mratsim/constantine/blob/618d8b3492980f12f7a51e7946abaca4469442f5/constantine/named/zoo_endomorphisms.nim#L110-L129

Unfortunately, 64 bits was checked in and performance figures were misleading and up to 3x faster than expected in fef6fdcdc3f256fb71a3ee2e28bff80000bbb33d from 3 weeks ago. This has not made the v0.1.0 release from 7 weeks ago.

zkalc integration #425 is also correct.