mratsim / weave

A state-of-the-art multithreading runtime: message-passing based, fast, scalable, ultra-low overhead
Other
532 stars 22 forks source link

Error: undeclared identifier: 'gebb_ukernel_int_x86_AVX512' #189

Closed bung87 closed 1 year ago

bung87 commented 1 year ago

https://github.com/nim-lang/Nim/actions/runs/3605850532/jobs/6076629541

/home/runner/work/Nim/Nim/pkgstemp/weave/benchmarks/matmul_gemm_blas/gemm_pure_nim/common/gemm_ukernel_dispatch.nim(67, 29) Error: undeclared identifier: 'gebb_ukernel_int_x86_AVX512'
  candidates (edit distance, scope distance); see '--spellSuggest': 
   (2, 4): 'gebb_ukernel_int32_x86_AVX512' [proc declared in /home/runner/work/Nim/Nim/pkgstemp/weave/benchmarks/matmul_gemm_blas/gemm_pure_nim/common/gemm_ukernel_generator.nim(47, 16)]
   (2, 4): 'gebb_ukernel_int64_x86_AVX512' [proc declared in /home/runner/work/Nim/Nim/pkgstemp/weave/benchmarks/matmul_gemm_blas/gemm_pure_nim/common/gemm_ukernel_generator.nim(47, 16)]
Vindaar commented 1 year ago

This is due to the change of how the int types behave. The name of the kernel is constructed based on the type name. Now that int matches int32 / int64 (depending on platform), the name is wrong.

bung87 commented 1 year ago

fixed in nim devel