search

mraygalaxy / pianod-mobile

Mobile application to control Pianod
3 stars 3 forks source link

Simple breakout for activityIndicator #1

Closed chinasaur closed 11 years ago

chinasaur commented 11 years ago

Hey, so it's a pretty small change, but I tried to break out the activityIndicator into its own module. Assuming this works properly, I'll plan to continue breaking more pieces out. This refactoring is an easy way to get my feet wet on this, plus I think it's useful.

I tested it and it seems to work as before, but let me know if you have problems or concerns.

chinasaur commented 11 years ago

Ah cool. The last two commits were on other things, substantially more changes than when I made the original pull request. I guess I should send you pull requests from a branch or something to keep newer commits from getting mixed in? Not much experience with branching in Git, but I know it works well.

The newer stuff is refactoring in preparation for breaking out the different views into their own modules. I will also probably move some code into OO patterns unless you prefer to just keep modularity through modules without objects? I think either way is fine.

Still haven't actually added any features, but think I corrected a bug with a return statement out of place (original line 356).