mraza007 / useful-bookmarks

Basically my firefox bookmarks with better search
https://bookmarks-flask.herokuapp.com/
MIT License
28 stars 16 forks source link

Removing Duplicates from Bookmarks.md file #10

Open mraza007 opened 5 years ago

mraza007 commented 5 years ago

Removing duplicates from the Bookmarks file

Xiaoy312 commented 5 years ago

The links in the html and the markdown doesn't really match up. I assume you want to merge them and then remove the duplicates?

mraza007 commented 5 years ago

Yup I am thinking of gettting rid of markdown and create this into full fledge bookmarks manager with tags and better sorting do you want to collaborate on this ?

Xiaoy312 commented 5 years ago

We can keep the markdown. it doesn't hurt too much to support it. And, it is possible to include tags with them too, like:

mraza007 commented 5 years ago

Oh that sounds cool I am trying to create this into full fledge bookmarks manager so then we can open source it and people can use it what you think

On Mon, Oct 7, 2019 at 9:04 PM Xiaotian Gu notifications@github.com wrote:

We can keep the markdown. it doesn't hurt too much to support it. And, it is possible to include tags with them too, like:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mraza007/useful-bookmarks/issues/10?email_source=notifications&email_token=AFAYFUKE4MCTLJEN7YFUNJTQNPMATA5CNFSM4I6LFSYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASJJYA#issuecomment-539268320, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAYFUKFEMXBNVA7GBKF36DQNPMATANCNFSM4I6LFSYA .

Xiaoy312 commented 5 years ago

Btw, the duplicates has been removed in #11. There, it seems that there were a few links that was in the old md, but not the html. I added them back in #12.

mraza007 commented 5 years ago

Did you create a PR so I merge

On Mon, Oct 7, 2019 at 9:14 PM Xiaotian Gu notifications@github.com wrote:

Btw, the duplicates has been removed in #11 https://github.com/mraza007/useful-bookmarks/pull/11. There, it seems that there were a few links that was in the old md, but not the html. I added them back in #12 https://github.com/mraza007/useful-bookmarks/pull/12.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mraza007/useful-bookmarks/issues/10?email_source=notifications&email_token=AFAYFUKLKIPHKBQ7MU4Z7BTQNPNGBA5CNFSM4I6LFSYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASJYPY#issuecomment-539270207, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAYFUPRQL7DJSBHT4EX6X3QNPNGBANCNFSM4I6LFSYA .

Xiaoy312 commented 5 years ago

Yup #12 is the new one.

Xiaoy312 commented 5 years ago

Not to rain on your parade, but it seems to be a lot of pain to manage your personal bookmarks in a git repo. And, then finding a service to publish/host it. As compared to just hitting Control+D (hotkey to favorite a web page). But, it could somewhat work as a some kind of public service (eg: useful links for [new,c#/nodejs...] programmer) to be shared.

mraza007 commented 5 years ago

Yup Basically that was my point

On Mon, Oct 7, 2019 at 9:20 PM Xiaotian Gu notifications@github.com wrote:

Not to rain on your parade, but it seems to be a lot of pain to manage your personal bookmarks in a git repo. And, then finding a service to publish/host it. But, it could somewhat work as a some kind of publish service (eg: useful links for [new,c#/nodejs...] programmer).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mraza007/useful-bookmarks/issues/10?email_source=notifications&email_token=AFAYFUKQGSBF3G2DQEN3H7DQNPN6VA5CNFSM4I6LFSYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASKCRI#issuecomment-539271493, or mute the thread https://github.com/notifications/unsubscribe-auth/AFAYFUOAP3T4DJHDGTH4ZQTQNPN6VANCNFSM4I6LFSYA .

Xiaoy312 commented 5 years ago

@mraza007 This is issue can be closed. In case you've missed my comment, the duplicated have already been removed in #11.