search

mrb0nj / Slack.Webhooks

Even simpler integration with Slack's Incoming and Outgoing webhooks
MIT License
173 stars 53 forks source link

Custom emoji #61

Closed winzig closed 4 years ago

winzig commented 6 years ago

Would it make sense to have the capability to specify custom Emoji? This could be used both for custom emoji defined by individual Slack teams, as well as for missing emoji (e.g. I don't see 🤑 in the Emoji class currently).

Something along the lines of:

var emoji = new Emoji(":money_mouth_face:");

pmacca commented 6 years ago

I tend to agree the existing list appears hard to maintain and extend. The ability to add any emoji name would be more flexible.

mrb0nj commented 5 years ago

I know this ticket has been open a loooooooong time but I would appreciate your thoughts on PR #67 if you get a chance.

also a pre-release version here https://github.com/mrb0nj/Slack.Webhooks/packages/42275

winzig commented 5 years ago

@mrb0nj I skimmed the PR, if the changes are what I think they are (moving to using ":string:" syntax to allow for custom emoji, with constants to cover most of the current emojis for easier reference), then it looks good to me, thanks!

mrb0nj commented 5 years ago

Yup that about sums it up, doing my best not to break anyone already using the constant Enum values in the process 👍