search

mrbrdo / spree_mobility

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Add relation types translations #9

Closed Kulgar closed 2 years ago

Kulgar commented 2 years ago

Hi @mrbrdo

I've added translations for relation types from related products extension. I don't know how to handle correctly the fact that the extension may not be used in Spree. Any idea?

Otherwise, I just added code based on what you did for option types and payment method.

Thanks!

mrbrdo commented 2 years ago

@Kulgar thanks, this is nice. However I think it should be as its own gem, since it's related to a Spree extension and not the core Spree. It should be pretty easy to put that in a new gem (with a Rails engine). For example you can look at this simple spree extension of mine: https://github.com/mrbrdo/spree_dpd Especially if you look at the code in the first commit only, it is basically a nice skeleton for a spree extension gem, which I used a few times for different spree extensions I've made for myself.