search

mrbuilder1961 / ChatPatches

A Minecraft client-side mod that touches up Minecraft's mundane chat, with configurability in mind!
GNU Lesser General Public License v3.0
48 stars 18 forks source link

Chat fps drop #102

Closed MrRoxandi closed 1 year ago

MrRoxandi commented 1 year ago

Description

I'm not sure exactly what the problem is, but after installing the mod, I'm experiencing a drop in fps by about 20-40 frames when opening chat. After that, everything goes back to normal.

mrbuilder1961 commented 1 year ago

i would also appreciate a small video or photo with the f3 debug pie and graph enabled, then opening the chat and sending a message or something.

MrRoxandi commented 1 year ago

Disc: I apologize for not providing enough information initially, I'm still new to github and making these kinds of "posts". After seeing severe fps drops, I pressed F3+D and the chat cleared. The drops have gotten smaller, but are still observed and seem to grow a little bit at a time.

изображение изображение изображение

mrbuilder1961 commented 1 year ago

ok thanks for all the information, although i noticed the log you sent was from the server and not the client. i apologize, i probably should have specified that, but i need a client side log bc chat patches doesn't do anything server side.

i will continue to look into this, but know it could take a little while. definitely keeping it high priority though!

also: does this happen on other servers and worlds or in any other mod packs? and if anyone you play with uses this version could you ask them? thanks 🙏😊

MrRoxandi commented 1 year ago

I did not understand what server log you were talking about because the Minecraft logs I sent you were from the latest.log file. It was in the log folder, as was the chatlog.json file. I hardly ever play in single world, but the same problem is observed there. As for using this mod separately in other mod packs, I didn't see any such drops in version 1.19.4, but I can't prove it as that pack has long since been lost. My friend and colleague who used your mod was the first to point out the frame drop problem, and then rudely abandoned it. Our packs are very different, so I think it is almost irrelevant where this mod stands. Well, and it says here that the problems started after I received an update to 1.20, because before that I suffered with a couple of other mods like: morechathistory, chat utils and a couple of other useful mods, which I safely removed after the release of the chat patches.

mrbuilder1961 commented 1 year ago

sorry, that was the right log file i misread it. thanks for the other info, i appreciate it. i can understand why your friend would "take a break" if this issue kept happening lol.

now looking into the log a little more, it says there were 2,260 saved messages restored into chat. i'm not sure how much storage that takes up on your computer, but i would consider at least moving that file elsewhere (so chat patches thinks it's empty) and seeing if the problem resolves.

if this does end up being a solution (clearing the chat log), it might take a while as said before bc that would require a lot more data compression shenanigans. this actually makes me wonder if your friend who dropped the mod had a lot of chat log messages too?

MrRoxandi commented 1 year ago

We just work as administrators of one minecraft server, it is vital for us to store a lot of messages that appear in chat. I also ask my colleagues to upload the same information that I sent you, maybe it will help in some way. On the subject of the number of posts. My computer is quite powerful (ryzen 7 3700x + 32 GB ddr4 if needed). If you need to allocate more RAM for gaming, no problem. I will also soon try to send you the information of my colleague who has agreed to provide it.

MrRoxandi commented 1 year ago

Also about clearing the message log. I did as you asked, then simulated active server chat via command block in single world. The situation happened again, I restarted the game and recorded it on video. I have sent all the necessary files in this post, and the mod list has not changed. minecraft logs https://mclo.gs/gl1aR3u chatlogs.json https://mclo.gs/HL0gXmQ

{
  "time": true,
  "timeDate": "HH:mm",
  "timeFormat": "[$]",
  "timeColor": 10658466,
  "hover": true,
  "hoverDate": "MM/dd/yyyy",
  "hoverFormat": "$",
  "hoverColor": 16777215,
  "counter": false,
  "counterFormat": "\u00268(\u00267x\u0026r$\u00268)",
  "counterColor": 16777045,
  "counterCompact": false,
  "counterCompactDistance": 4,
  "boundary": true,
  "boundaryFormat": "\u00268[\u0026r$\u00268]",
  "boundaryColor": 5636095,
  "chatLog": true,
  "chatWidth": 451,
  "chatMaxMessages": 16384,
  "chatNameFormat": "\u003c$\u003e",
  "shiftChat": 40,
  "messageDrafting": false,
  "searchDrafting": true,
  "hideSearchButton": false,
  "vanillaClearing": false,
  "copyColor": 5636095,
  "copyReplyFormat": "/msg $ "
}

video https://youtu.be/RzgMLcwoj4I

MrRoxandi commented 1 year ago

Also, here's some information from a colleague of mine mod list изображение chatlog.json https://mclo.gs/PA7kqcP minecraft log https://mclo.gs/uOCiMOO chatpatches.json

{
  "time": true,
  "timeDate": "HH:mm:ss",
  "timeFormat": "[$]",
  "timeColor": 10658466,
  "hover": true,
  "hoverDate": "MM/dd/yyyy",
  "hoverFormat": "$",
  "hoverColor": 16777215,
  "counter": false,
  "counterFormat": "\u00268(\u00267x\u0026r$\u00268)",
  "counterColor": 16777045,
  "counterCompact": true,
  "counterCompactDistance": 7,
  "boundary": true,
  "boundaryFormat": "\u00268[\u0026r$\u00268]",
  "boundaryColor": 5636095,
  "chatLog": true,
  "chatWidth": 403,
  "chatMaxMessages": 32767,
  "chatNameFormat": "\u003c$\u003e",
  "shiftChat": 30,
  "messageDrafting": true,
  "searchDrafting": true,
  "hideSearchButton": false,
  "vanillaClearing": false,
  "copyColor": 5636095,
  "copyReplyFormat": "/msg $ "
}

video

https://github.com/mrbuilder1961/ChatPatches/assets/120740818/74546d33-d484-4568-810c-cd5544b00458

mrbuilder1961 commented 1 year ago

thank you so much for all the information!! i've been pretty busy and continue to be, but i will try and reproduce the issue and see if i can track down where the bottleneck is. sorry to keep you waiting with a laggy mod, hope to get this fixed ASAP 🤞🙏❤️

MrRoxandi commented 1 year ago

It's not a big deal. The situation is not as unpleasant as it may seem. A broken tab selector is more of a problem. But I really hope you do well :)

mrbuilder1961 commented 1 year ago

Still pretty busy, but I've been able to get my hands on a profiler and i can reproduce the issue. so when i have some time, this shouldn't be terribly hard to get under control. thanks for the patience 🙏 ❤️