mrbuilder1961 / ChatPatches

A Minecraft client-side mod that touches up Minecraft's mundane chat, with configurability in mind!
GNU Lesser General Public License v3.0
44 stars 16 forks source link

Very Many Enhancements & Bugfixes #104

Closed hexadecimal233 closed 11 months ago

hexadecimal233 commented 11 months ago

Fixes #101 Fix autocompletion up key shows the message history instead of the prev suggestion Fixed elements added by other mods (like no chat reports) are not clickable Fix Tweakeroo message draft not working lazydfu no more needed Created a new class for search button Add Ignore hide message packet toggle Fix chat focus bug again Partially fixed #99 by disabling player name format when format is "<$>"

mrbuilder1961 commented 11 months ago

WOW! i never expected anyone else to actually contribute code changes to the project, thank you!! i'm not going to merge it just yet bc i want to look it over thoroughly and make sure it's formatted the same and it all works.

i really really appreciate it, and if you join the discord let me know so i can give you your contribution role!

mrbuilder1961 commented 11 months ago

also could you log your changes in changelog.md?

hexadecimal233 commented 11 months ago

Just updated the changelog and should be able to merge it :P Also the cps$ can be removed, mixin will add them

mrbuilder1961 commented 11 months ago

yeah i realized the mixin thing way after i alr added them so i just kept them anyway.

btw this is looking to be almost done, i'm just trying out a few things on my end to verify it's all working smoothly. i might have to exclude a couple parts from being approved (if i can even do that) just bc i'm already implementing a few things you did here.

thanks again!

mrbuilder1961 commented 11 months ago

oh also idk how to do this, but do you think you could give me write permissions on your fork just so i could do a couple style/writing changes? i'll leave the important logic and code to requests 😄

hexadecimal233 commented 11 months ago

I have added you to the collaborators and these changes should be fine.