mrbuilder1961 / ChatPatches

A Minecraft client-side mod that touches up Minecraft's mundane chat, with configurability in mind!
GNU Lesser General Public License v3.0
48 stars 18 forks source link

Unable use search Box #108

Closed MrRoxandi closed 1 year ago

MrRoxandi commented 1 year ago

Description

I have a problem where I am unable to use the search box if I install any other mods that modify the chat in any way.

How to reproduce

Add a mod that modifies the chat in any way. For example: Symbol Chat

Log file link

minecraft logs

Additional info

chatlog.json

{"messages":[],"history":[]} 

chatpatches.json

{
  "time": true,
  "timeDate": "HH:mm:ss",
  "timeFormat": "[$]",
  "timeColor": 16733695,
  "hover": true,
  "hoverDate": "MM/dd/yyyy",
  "hoverFormat": "$",
  "hoverColor": 16777215,
  "counter": true,
  "counterFormat": "\u00268(\u00267x\u0026r$\u00268)",
  "counterColor": 16777045,
  "counterCompact": false,
  "counterCompactDistance": 0,
  "boundary": true,
  "boundaryFormat": "\u00268[\u0026r$\u00268]",
  "boundaryColor": 5636095,
  "chatLog": true,
  "chatHidePacket": true,
  "chatWidth": 0,
  "chatMaxMessages": 16384,
  "chatNameFormat": "\u003c$\u003e",
  "shiftChat": 10,
  "messageDrafting": false,
  "searchDrafting": true,
  "hideSearchButton": false,
  "vanillaClearing": false,
  "copyColor": 5636095,
  "copyReplyFormat": "/msg $ "
} 

Mod List

изображение

mrbuilder1961 commented 1 year ago

like you can't click or tab to it at all? what about the chat field and the search button, can you interact with those?

MrRoxandi commented 1 year ago

I don't know how to get there using TAB, so I can't tell you. I haven't used one of these. I just can't click on that field. The chat field works correctly. The search settings button works as it should too.

hexadecimal233 commented 1 year ago

I cannot reproduce this with the same mod set in fabric, can you run the same mod set and see if it is resolved?

MrRoxandi commented 1 year ago

So, i run it on a fabric with a clear new pack. This issue still there mod list image video https://github.com/mrbuilder1961/ChatPatches/assets/120740818/d1a7d5a0-5345-4c15-9d94-f033748dca6c

mrbuilder1961 commented 1 year ago

ok, so the issue is (obviously) that the search field is not registering any clicks. i'm trying to look into the source code of Symbol Chat to see where it registers clicks, but I'm having a hard time with it. @replaceitem, could you let me know where your mouseClicked handlers are located so i can move my calls to avoid conflicts? thanks in advance, and sorry about the wait!

replaceitem commented 1 year ago

I looked into it, and it looks like this is the fault of symbol chat, since it's preventing any other widget apart from the chat box to be focused

https://github.com/replaceitem/symbol-chat/blob/2a74f24b6329b8f788dc8bd7b1178c111a792ae8/src/main/java/net/replaceitem/symbolchat/mixin/ChatScreenMixin.java#L51-L54

I will change that to only block focusing the symbol panel away from the chatbox.

replaceitem commented 1 year ago

Fixed it in https://github.com/replaceitem/symbol-chat/commit/46c7500889d42eba44057740b4a2b6fbdb620119 and tested it with this mod.

mrbuilder1961 commented 1 year ago

Awesome, thanks so much!! I really appreciate it 😄 that all being said, I can no longer reproduce the issue myself and it appears to be fixed, update should be releasing shortly.