search

mrbuilder1961 / ChatPatches

A Minecraft client-side mod that touches up Minecraft's mundane chat, with configurability in mind!
GNU Lesser General Public License v3.0
48 stars 18 forks source link

Chat doesnt show up - 194.5.0 #96

Closed AlfmanOO7 closed 1 year ago

AlfmanOO7 commented 1 year ago

Description

No chat messages will appear when I or others type in chat. My messages still get through (have checked using a linked discord channel), but all I see in my chat is my join message and some server messages (like /msg, /away, etc). This is only a server issue, I get chat messages fine on singleplayer (see attached image) issues

How to reproduce

join any server send/receive messages nothing appears

Expected result

you see the chat messages

Log file link

https://mclo.gs/FnK6a4S

Specs and Details

Required information:

mrbuilder1961 commented 1 year ago

do you have any images of what the messages look like without the mod installed, the ones you can't see?

AlfmanOO7 commented 1 year ago

image ^here I'm gonna mess around with removing other mods to see if I can find an incompatibility

mrbuilder1961 commented 1 year ago

ok ill work on this, do you know what mod/plugin changes your name color? or is that a scoreboard/team thing?

AlfmanOO7 commented 1 year ago

Name colours are done by LuckPerms

AlfmanOO7 commented 1 year ago

I have done more testing. The issue is not present on:

removing AuthMe and NoChatReports (individually) did not resolve the issue

mrbuilder1961 commented 1 year ago

could you try removing LuckPerms and/or disabling that name changer thing as well? i can't use my computer rn but tomorrow i can build a debug file w some loggers to help fix this issue.

AlfmanOO7 commented 1 year ago

Unfortunately, I am not an Admin on the server in question, so I am unable to change that. All I have been able to do is run a paper-only server to test on (no additional plugins). I could attempt to run a paper server with just LuckPerms, however, my knowledge of how plugins work is limited, and I also don't know the exact configs used by my server. For now, the previous version of ChatPatches is working.

mrbuilder1961 commented 1 year ago

ok, could you load this and send me the log after it errors? it doesn't try to fix it, but it logs some information for me to look at. the only difference is adding logpoints and changing the version. the sources file ends in -sources and the runnable is the other one. thanks! libs.zip

AlfmanOO7 commented 1 year ago

latest.log Here's the log after using that jar

mrbuilder1961 commented 1 year ago

ok, so i don't know what is causing this specific error but i can see the problem. but i'm wondering, do you have show advanced tooltips on?

(https://mclo.gs/bZMAK2H)

mrbuilder1961 commented 1 year ago

i can maybe look into this more tomorrow

AlfmanOO7 commented 1 year ago

ok, so i don't know what is causing this specific error but i can see the problem. but i'm wondering, do you have show advanced tooltips on?

(https://mclo.gs/bZMAK2H)

Yes I have it on

mrbuilder1961 commented 1 year ago

the issue seems to be that luckperms reformats the message to have the custom color in a different type of message. that really isn't too hard of an issue to fix, but it strips player data from the name (unlike vanilla, which adds some info you can see with advanced tooltips enabled).

if i can find a way to access the formatter luckperms uses to create the message, it should be pretty easy. however, idrk how to do that, so i'll have to do some digging.

AlfmanOO7 commented 1 year ago

good that you've figured out the issue. no worries if it takes a while to resolve it, thanks for looking into it!

mrbuilder1961 commented 1 year ago

ok try this for me and send the log! edit2: i made some other changes so try this one instead: libs.zip

AlfmanOO7 commented 1 year ago

sorry its taken me while to get back to you, had a very busy weekend. Here's the log: https://mclo.gs/SFQogYn

not sure if it's part of the debug version, or if you even intended this to happen, player names appeared twice: image

mrbuilder1961 commented 1 year ago

huh, that's odd. thanks for getting back to me, i'll take a look later today when i have some free time.

edit: i just remembered, could you check and see if you can hover over your (chat patches formatted) name and see if it has the proper tooltip/click event? thanks 😊

mrbuilder1961 commented 1 year ago

hey, so i checked the log, and it didnt have any extra data, which doesn't make sense because what i added always logs something. it looks like you loaded the old version by accident, but that's okay because i added a couple more logpoints anyway just in case. heres another updated file: (sorry theres no other way i know of 😣) for @AlfmanOO7 : libs.zip

AlfmanOO7 commented 1 year ago

another log: https://mclo.gs/OKFg1it

Hopefully its correct this time

mrbuilder1961 commented 1 year ago

ok great, thanks! i think i know how to remove the duped name, so i'll send another dev file later today, and when i do could you just lmk if it's working and send the log? i'll test as much as possible on my end too, of course 😄

mrbuilder1961 commented 1 year ago

ok i think this should work now!!!! please lmk asap if there are any more issues! @AlfmanOO7 => libs.zip

AlfmanOO7 commented 1 year ago

seems to work, player name colours aren't carried over, but I can fix that in the configs (all players will be same colour, but thats only an issue for admins and moderators) here's the log: Log I did encounter a crash when clicking on the time stamp decoration text config, here's the crash log for that if its something you didnt know about: Crash

AlfmanOO7 commented 1 year ago

Ok, turns out the crash occurs when I do anything in the mod's config menu, all the logs are the same though

~~Edit: More testing has lead me to find that messages sent via discord now cause me to crash: Crash Report; Log~~ Didn't read those crash reports hard enough before posting here, issue was with EMF not Chat Patches it seems, just a conincidence

mrbuilder1961 commented 1 year ago

yeah the crash is what i was talking about in the discord and why 194.5.0 doesn't have preview images (https://github.com/isXander/YetAnotherConfigLib/issues/87), I was just testing it at the same time and forgot to remove it from the debug jar, my bad. however, about the colors being erased, I think i might just have to put that on the backburner for now because i don't know how well that will mix with the config name format (because you can add colors there too) but i will try.

but other than that stuff, is everything else working okay?

AlfmanOO7 commented 1 year ago

I haven't had any issues other than the crash, so I'd say so, thanks!