search

mrbungle64 / ioBroker.ecovacs-deebot

Control your Ecovacs Deebot and yeedi vacuum cleaner with ioBroker
MIT License
59 stars 11 forks source link

add std test-and-release workflow #640

Closed mcm1957 closed 5 months ago

mcm1957 commented 5 months ago

This PR adds the ioBroker standard test-and-release workflow.

Please merge into you setup. Maybe this std workflow duplicates tests of nodejs.yml. So eventually you want to check / adapt / remove those workflows.

Although using the standard workflow is NOT mandatory the tests contained in it (or equivalent tests) are mandatory for an adapter to be listed at the repositories. Usinf the standard workflow redudes work needed to check as at least partly an automatic check can be performed.

Thnaks for your cooperation adn eventually merging the PR.

And THANKS A LOT that you spend time for an ioBroker adapter and provide it to others,

mrbungle64 commented 5 months ago

@mcm1957

This PR adds the ioBroker standard test-and-release workflow.

Please merge into you setup. Maybe this std workflow duplicates tests of nodejs.yml. So eventually you want to check / adapt / remove those workflows.

Thanks for your PR 👍🏻

mrbungle64 commented 5 months ago

Maybe I should bump the minimum required version of Node.js to 18.x Engine breaks builds #482

mcm1957 commented 5 months ago

No problem. It's completly OK to require node 18 in the meantime. Node 16 is no longer supported since months and ioBroker simply does not yet block it activly. Bute inode 16 is no longer required to be supported and ioBroker recommends node 18 since some time ago. Several adapters require node 18 minimum in the meantime.

You should:

mrbungle64 commented 5 months ago

@mcm1957 Thanks 👍🏻

You should:

  • adapt engines at package,json
  • remove node 16 from test-and-release workflow
  • increase at least the minor version number if you require node 18 or newer now.

Done 😉