search

mrbwaters / fire_drill

1 stars 4 forks source link

PC does not carry fall height with them between rooms #64

Open mrbwaters opened 2 years ago

mrbwaters commented 2 years ago

Example: Fall from really high in rm_3, fall through floor, hit platform at top of rm_2

Expected: Die

Observed: Live

jbussing commented 2 years ago

PC also does not persist the fall state when transitioning rooms

jbussing commented 2 years ago

Looks like the last PR fixed this.

jbussing commented 2 years ago

Im noticing that when Im in a fall while transitioning and im colliding with a ladder the pc enters idle, it's not bad but intuitively i think the PC should remain in the fall state.

mrbwaters commented 2 years ago

Agreed. They should continue the fall.

Sent via Superhuman ( @.*** )

On Wed, Jan 05, 2022 at 8:25 PM, jbussing < @.*** > wrote:

Im noticing that when Im in a fall while transitioning and im colliding with a ladder the pc enters idle, it's not bad but intuitively i think the PC should remain in the fall state.

— Reply to this email directly, view it on GitHub ( https://github.com/mrbwaters/fire_drill/issues/64#issuecomment-1006274727 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/ALFB6RRE3HQJJMXBJHKXWILUUUKSJANCNFSM5LGAODPQ ). You are receiving this because you authored the thread. Message ID: <mrbwaters/fire_drill/issues/64/1006274727 @ github. com>

mrbwaters commented 2 years ago

It looks like this bug is still present. If you fall from the top of rm_2 through the pit onto the top platform in rm_1, you survive the landing.

jbussing commented 2 years ago

There is a bug where if you are running from a fall you may also survive the fall. Will squash that on the PR after the new levels