search

mrbwaters / fire_drill

1 stars 4 forks source link

game states v1 #73

Closed mrbwaters closed 2 years ago

mrbwaters commented 2 years ago

Do not merge!

@eddivita My game fsm reorg made all sound calls crash the game 😢

I couldn't figure out how to fix so I just commented out all sounds for testing. Mind taking a look at this branch and fixing if you can?

eddivita commented 2 years ago

Audio fixed.

Ideally the bgm_play() function would be called from a function that handles switching rooms to make sure it runs immediately after the room starts, but seems like room switching happens in a few different places - the room exits, player death, and the menu. So I put bgm_play() in the room_start event of meta_game, which works, but feels a little arbitrary since all objects could have a room_start event.

Anyway, should be good to merge now if the audio was the only issue.