mrc-ide / drjacoby

Flexible Markov chain monte carlo via reparameterization
https://mrc-ide.github.io/drjacoby/
Other
12 stars 6 forks source link

Initial parameters argument #13

Closed pwinskill closed 3 years ago

pwinskill commented 4 years ago

Separate initial parameters argument, removing from df_params. Optional - not needed if stating values can be drawn from min & max. Warning that it is needed if either of min or max = Inf Input is a list, whcih can contain a vector for each chain of a parameter

pwinskill commented 4 years ago

Tibbles make list columns easy nad the init params could be a list column.

On this same topic. I remember us discussing a more intiuitive input format for df_params. A tibble can be entered rowwise, which may be an option (although additional dependency):

tribble(
  ~x, ~y,  ~z,
  "a", 2,  3.6,
  "b", 1,  8.5
)
#> # A tibble: 2 x 3
#>   x         y     z
#>   <chr> <dbl> <dbl>
#> 1 a         2   3.6
#> 2 b         1   8.5
bobverity commented 3 years ago

Solved with define_params() function. Using dataframe instead of tibble