search

mrc-ide / drjacoby

Flexible Markov chain monte carlo via reparameterization
https://mrc-ide.github.io/drjacoby/
Other
12 stars 5 forks source link

Plot speed #76

Closed pwinskill closed 2 years ago

pwinskill commented 2 years ago

Attemp to fix #74

Parameter plots are now displayed within the plotting loop and the user is asked each time for keyboard input to:

  1. (Create and) View next plot.
  2. Stop viewing plots, but create and return a list of all plot objects.
  3. Exit with no further output.

It doesn't feel like super smooth UI, but I struggled to think of another way.

pwinskill commented 2 years ago

This is whatit does no?! Each iteration creates and then (optionally) displays a plot with a user prompt. That way if the users looks at e.g. the first 2, then quits, only 2 plots have ever been created.

bobverity commented 2 years ago

Sorry, didn't realise the display() bit had been taken inside the creation loop. Happy to accept merge!