mrc-ide / epireview

https://mrc-ide.github.io/epireview/
Other
26 stars 2 forks source link

epireview major release #103

Closed sangeetabhatia03 closed 2 months ago

sangeetabhatia03 commented 2 months ago

This PR constitutes a major release of epireview bringing together the features and bug-fixes from develop into main. I have updated NEWS.md summarising the key updates.

Checklist:

CosmoNaught commented 2 months ago

@sangeetabhatia03 tests passing see below however


── R CMD check results ──────────────────────────── epireview 1.2.10 ────
Duration: 42.3s

❯ checking R code for possible problems ... NOTE
  load_epidata: no visible global function definition for ‘read.csv2’
  Undefined global functions or variables:
    read.csv2
  Consider adding
    importFrom("utils", "read.csv2")
  to your NAMESPACE file.

0 errors ✔ | 0 warnings ✔ | 1 note ✖

is there a reason why here you use read.csv2()? we consistently use read_csv() just wondering if this is by design or if I can push a fix to be consistent.

sangeetabhatia03 commented 2 months ago

i did add import directive for read.csv.. and yes i am taking every opportunity to reduce our dependancy footprint, hoping to move away from readr, dplyr etc altogether in a few release cycles. I am happy to edit if you think this is not a good reason.