Closed shaziaruybal closed 2 weeks ago
@tristan-myles just took a peek at the conflicts, I think the error message may need to also be updated for custom_palette()
to be in line with cli_()
In addition to my two comments on the files changed:
- devtools::check is failing because load-filter-view-epidata.Rmd no longer compiles due to the changes in forest_plot.R. Could you check the functions used in this vignette. I think you just need to provide custom palettes? Additionally, to confirm, is this the expected behaviour when now custom palette is provided?
- I've bumped the version to 1.3.4 based on the anticipated merge of Sangeeta's PR, can you just add a brief description of the changes introduced in this PR in the NEWS.md file. A brief one-liner is fine. :)
we fixed a minor bug when newest version of develop
branch was merged and now builds - have added description to NEWS.md
Pull Request
This PR responds to #20 and updates the default color palette to a hopefully nicer one from
ggsci
. It also fixes a bug (see 8a2d5bbe3fe56bee407ad056e746edce90fe450f and 193f172f8123e6eec4e3d1a8723445360011ee9f).Additional changes:
custom_palette()
was created to hopefully aid users to build their own custom palettes, especially if they want to visualise parameters with "multi-country" labels (eg "Guinea, Liberia, Sierra Leone") since the default palette will only work for single-country labels eg ("Guinea").custom_palette()
have also been addedExample usage of
custom_palette()
:Checklist:
DESCRIPTION
DESCRIPTION
(I am now working off of an earlier version so didn't update any version numbers)NEWS.md
testthat
devtools::install_local("<path-to-epireview>")
priority-pathogens