search

mrc-ide / epireview

https://mrc-ide.github.io/epireview/
Other
26 stars 2 forks source link

Case-insensitive argument to load_epidata #116

Closed sangeetabhatia03 closed 1 month ago

sangeetabhatia03 commented 1 month ago

As requested in #96 I turn the provided argument to lower case before running validity checks. I have updated the tests, documentation and bumped up version number and NEWS. To test this PR, checkout the branch and do

devtools::check()

You should see no errors, warnings or notes. Further, if you either install and load the package or do, 

devtools::load_all()

then, the following should work

load_epidata('ebola')
load_epidata('EBOLA')
load_epidata('eBoLa')
tristan-myles commented 1 month ago

@sangeetabhatia03 The base was originally set to merge to main. I'm assuming this was by mistake, but want to confirm? I've changed the base to develop and will merge once you confirm.

sangeetabhatia03 commented 1 month ago

yes sorry! meant to merge into develop, not main!