Closed sangeetabhatia03 closed 2 months ago
For your attention @CosmoNaught
Happy in principle to approve pending advice on the following;
get_parameter
is now correctly exported and documented. Have pushed fix to branch.load_epidata()
, to resolve the documentation warning. The warning clearly arises from this double commenting @sangeetabhatia03 can we enable this function please? https://github.com/mrc-ide/epireview/blob/a150eb0c90af347053b34d8d4256fda992d9abcc/R/prep_data_forest_plots.R#L43-L67meta
package in Suggests
. Unsure if necessary for package but I would suggest moving to Imports
if possible.Please advise on how to proceed. Other than this the branch passes all checks now (bar the following)
── R CMD check results ───────────────────────────────────────────── epireview 1.1.3 ────
Duration: 3m 28.3s
❯ checking Rd cross-references ... WARNING
Missing link or links in documentation object 'get_parameter.Rd':
‘load_epidata()’
See section 'Cross-references' in the 'Writing R Extensions' manual.
0 errors ✔ | 1 warning ✖ | 0 notes ✔
This PR follows on Tristan's PR that cleans up the vignettes. This PR:
The package now builds without any errors and all tests pass. Bumping up version number is not needed because we are not adding any new functionality.
To test this PR, clone the repository or pull the latest changes from this branch if already have a clone. Then in an R session, run
Expect 0 errors