search

mrc-ide / epireview

https://mrc-ide.github.io/epireview/
Other
29 stars 2 forks source link

Case fatality ratio not rate #79

Open ruthmccabe opened 5 months ago

ruthmccabe commented 5 months ago

We currently label the CFR as "case fatality rate" but this should be updated everywhere to "case fatality ratio".

joshwlambert commented 4 weeks ago

In {epiparameter} we have updated the package to work with CFR parameters (https://github.com/epiverse-trace/epiparameter/blob/main/inst/extdata/data_dictionary.json#L23 & https://github.com/epiverse-trace/epiparameter/blob/main/R/epiparameter.R#L52).

We've labeled it case fatality risk. Was there a specific reason you went with ratio? It would be good to be consistent between the packages.

I'm happy to submit a PR to {epireview} addressing this issue and updating {epiparameter} once the terminology is agreed.

ruthmccabe commented 4 weeks ago

Thanks Josh!

We went with ratio because we have found that to be the most common terminology in the field, also because it is looking at the ratio of deaths to cases. What was the reason for using "risk"? Agree let's be consistent on language.

joshwlambert commented 4 weeks ago

In {epiparameter} I've followed the terminology used in {cfr}. A discussion can be found here: https://github.com/epiverse-trace/cfr/issues/130.

I don't have a personal preference. If {epireview} and {cfr} differed then I would need to think which package is better to standardise terminology with. Although we should be able to setup aliases to ensure both work for users.