mrc-ide / epireview

https://mrc-ide.github.io/epireview/
GNU General Public License v3.0
25 stars 2 forks source link

Add `get_key_columns()` function #97

Closed joshwlambert closed 1 week ago

joshwlambert commented 4 weeks ago

This PR addresses #63 by adding a new exported function get_key_columns() which takes in parameter data from {epireview} and returns the key columns with respect to the chosen epidemiological parameter (e.g. CFR or delay distribution).

This was worked on by @ruthmccabe and myself during the {epireview} dev day.

New unit tests have been added for the new function.

ruthmccabe commented 2 weeks ago

with this, it would be amazing if we could rebase from the main branch which has the doi/article_info column and add this to the key_cols function (lines 55 - 56)

joshwlambert commented 2 weeks ago

Good idea. I think it should be rebased onto the develop branch, as this seems to be the most up-to-date.

I've finished implementing everything for this PR, so happy for anyone from the epireview team to take it from here, and rebase or modify this PR in whichever way is best.

ruthmccabe commented 2 weeks ago

@joshwlambert because this is included in the get_specific_params branch and I am making an update in relation to the comment made by @sangeetabhatia03 on that PR I now propose closing this and including it altogether, but let me know if you disagree!

joshwlambert commented 2 weeks ago

@ruthmccabe that's fine with me. There are 4 commits on the get_key_cols branch that are not on the get_specific_params branch. These will need to be either merged or manually added if this PR is closed and the changes are made on get_specific_params branch/PR.